feat(tape-to-node-test): first draft
#296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustinMauroy
added
the
awaiting reviewer
brunocroh
reviewed
Dec 18, 2025
Co-authored-by: Bruno Rodrigues <[email protected]>
brunocroh
reviewed
Jan 6, 2026
Comment on lines
+66
to
+136
| const tapeImports = getNodeImportStatements(root, 'tape'); | ||
| const tapeRequires = getNodeRequireCalls(root, 'tape'); | ||
| const tapeImportCalls = getNodeImportCalls(root, 'tape'); | ||
|
|
||
| if ( | ||
| tapeImports.length === 0 && | ||
| tapeRequires.length === 0 && | ||
| tapeImportCalls.length === 0 | ||
| ) { | ||
| return null; | ||
| } | ||
|
|
||
| let testVarName = 'test'; | ||
|
|
||
| // 1. Replace imports | ||
| for (const imp of tapeImports) { | ||
| const defaultImport = imp.find({ | ||
| rule: { kind: 'import_clause', has: { kind: 'identifier' } }, | ||
| }); | ||
| if (defaultImport) { | ||
| const id = defaultImport.find({ rule: { kind: 'identifier' } }); | ||
| if (id) testVarName = id.text(); | ||
| edits.push( | ||
| imp.replace( | ||
| `import { test } from 'node:test';${EOL}import assert from 'node:assert';`, | ||
| ), | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| for (const req of tapeRequires) { | ||
| const id = req.find({ | ||
| rule: { kind: 'identifier', inside: { kind: 'variable_declarator' } }, | ||
| }); | ||
| if (id) testVarName = id.text(); | ||
| const declaration = req | ||
| .ancestors() | ||
| .find( | ||
| (a) => | ||
| a.kind() === 'variable_declaration' || | ||
| a.kind() === 'lexical_declaration', | ||
| ); | ||
| if (declaration) { | ||
| edits.push( | ||
| declaration.replace( | ||
| `const { test } = require('node:test');${EOL}const assert = require('node:assert');`, | ||
| ), | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| for (const call of tapeImportCalls) { | ||
| const id = call.find({ | ||
| rule: { kind: 'identifier', inside: { kind: 'variable_declarator' } }, | ||
| }); | ||
| if (id) testVarName = id.text(); | ||
| const declaration = call | ||
| .ancestors() | ||
| .find( | ||
| (a) => | ||
| a.kind() === 'variable_declaration' || | ||
| a.kind() === 'lexical_declaration', | ||
| ); | ||
| if (declaration) { | ||
| edits.push( | ||
| declaration.replace( | ||
| `const { test } = await import('node:test');${EOL}const { default: assert } = await import('node:assert');`, | ||
| ), | ||
| ); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This logic is quite the same for the 3 difference scenarios, I think it can be simplified to code below
Suggested change
| const tapeImports = getNodeImportStatements(root, 'tape'); | |
| const tapeRequires = getNodeRequireCalls(root, 'tape'); | |
| const tapeImportCalls = getNodeImportCalls(root, 'tape'); | |
| if ( | |
| tapeImports.length === 0 && | |
| tapeRequires.length === 0 && | |
| tapeImportCalls.length === 0 | |
| ) { | |
| return null; | |
| } | |
| let testVarName = 'test'; | |
| // 1. Replace imports | |
| for (const imp of tapeImports) { | |
| const defaultImport = imp.find({ | |
| rule: { kind: 'import_clause', has: { kind: 'identifier' } }, | |
| }); | |
| if (defaultImport) { | |
| const id = defaultImport.find({ rule: { kind: 'identifier' } }); | |
| if (id) testVarName = id.text(); | |
| edits.push( | |
| imp.replace( | |
| `import { test } from 'node:test';${EOL}import assert from 'node:assert';`, | |
| ), | |
| ); | |
| } | |
| } | |
| for (const req of tapeRequires) { | |
| const id = req.find({ | |
| rule: { kind: 'identifier', inside: { kind: 'variable_declarator' } }, | |
| }); | |
| if (id) testVarName = id.text(); | |
| const declaration = req | |
| .ancestors() | |
| .find( | |
| (a) => | |
| a.kind() === 'variable_declaration' || | |
| a.kind() === 'lexical_declaration', | |
| ); | |
| if (declaration) { | |
| edits.push( | |
| declaration.replace( | |
| `const { test } = require('node:test');${EOL}const assert = require('node:assert');`, | |
| ), | |
| ); | |
| } | |
| } | |
| for (const call of tapeImportCalls) { | |
| const id = call.find({ | |
| rule: { kind: 'identifier', inside: { kind: 'variable_declarator' } }, | |
| }); | |
| if (id) testVarName = id.text(); | |
| const declaration = call | |
| .ancestors() | |
| .find( | |
| (a) => | |
| a.kind() === 'variable_declaration' || | |
| a.kind() === 'lexical_declaration', | |
| ); | |
| if (declaration) { | |
| edits.push( | |
| declaration.replace( | |
| `const { test } = await import('node:test');${EOL}const { default: assert } = await import('node:assert');`, | |
| ), | |
| ); | |
| } | |
| } | |
| const tapeImports = getNodeImportStatements(root, 'tape'); | |
| const tapeRequires = getNodeRequireCalls(root, 'tape'); | |
| const tapeImportCalls = getNodeImportCalls(root, 'tape'); | |
| const modDeps = [ | |
| ...tapeImports.map((node) => ({ | |
| node, | |
| import: `import { test } from 'node:test';${EOL}import assert from 'node:assert';`, | |
| })), | |
| ...tapeRequires.map((node) => ({ | |
| node, | |
| import: `const { test } = require('node:test');${EOL}const assert = require('node:assert');`, | |
| })), | |
| ...tapeImportCalls.map((node) => ({ | |
| node, | |
| import: `const { test } = await import('node:test');${EOL}const { default: assert } = await import('node:assert');`, | |
| })), | |
| ]; | |
| if (modDeps.length === 0) { | |
| return null; | |
| } | |
| let testVarName = 'test'; | |
| // 1. Replace imports | |
| for (const mod of modDeps) { | |
| if (mod.node.kind() === 'variable_declarator') { | |
| mod.node = mod.node.parent(); | |
| } | |
| const binding = mod.node.find({ | |
| rule: { | |
| any: [ | |
| { kind: 'identifier', inside: { kind: 'variable_declarator' } }, | |
| { | |
| kind: 'identifier', | |
| inside: { kind: 'import_clause', stopBy: 'end' }, | |
| }, | |
| ], | |
| }, | |
| }); | |
| if (binding) testVarName = binding.text(); | |
| edits.push(mod.node.replace(mod.import)); | |
| } |
ljharb
reviewed
Jan 7, 2026
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
(btw the diff would read cleaner if it was "output" instead of "expected", because then "input" would be sorted before "output" instead of the reverse)
some of my comments apply on all the input/expected combos, so i'll post this now before being exhaustive
Comment on lines
+16
to
+18
| // TODO: test.onFinish(() => { | ||
| // console.log('finished'); | ||
| // }); |
Member
There was a problem hiding this comment.
if this is a TODO for you, then this PR should probably still be a draft; if not, then it would be better to make it fail VERY LOUDLY so that users are aware they have to manually fix something. it's not ok to just silently elide their code :-)
Comment on lines
+4
to
+6
| test('sync test with no args', async () => { | ||
| const a = 1; | ||
| }); |
Member
There was a problem hiding this comment.
a sync text needs to always be an async function in the test runner? O.o that seems like it introduces an unnecessary performance hit
Comment on lines
+4
to
+6
| test("require test", async (t) => { | ||
| assert.strictEqual(1, 1); | ||
| // t.end(); |
Member
There was a problem hiding this comment.
this line should either be removed, or it should end up with whatever the node test runner has to say "this test is done and if you get more assertions later, it should error". (if it doesn't have that, then the node runner doesn't have sufficient features for a codemod from tape to be appropriate)
brunocroh
added
awaiting author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Close #260